Review Request 116736: Bug Fixed - The plasma-media center displays the time in AM between 12 noon and 1pm

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116736/#review52694
-----------------------------------------------------------


Hey,

Thanks for your patch, unfortunately, the changes are wrong, I've explained why inline.

For reference, also see the following two review requests:

https://git.reviewboard.kde.org/r/116460/
https://git.reviewboard.kde.org/r/115870/

I wonder if you're just woefully unlucky, or if this bug is listed somewhere, in the latter case, it should probably link to this review request, or one of the above. It's getting a bit tiring to explain the exact same mistake to someone else every week. :)


mediaelements/mediaplayer/MusicStats.qml
<https://git.reviewboard.kde.org/r/116736/#comment37160>

    Hardcoding colors is a complete no-go. It will clash with themes, and makes the UI unthemable. Hardcoding the color like this is also very ugly, use two labels each, if you and set the according font.color property.
    
    Also, this change seems unrelated, and should not be part of this review.



mediaelements/mediawelcome/HomeScreenFooter.qml
<https://git.reviewboard.kde.org/r/116736/#comment37159>

    Congrats, you're the third person to come up with this solution.
    
    Unfortunately, it's wrong: The time will be displayed in the wrong format for most locales.
    
    You should use the time dataengine, and Qt.formatTime (for example) to format the time string.


- Sebastian Kügler


On March 11, 2014, 7:14 p.m., Atul Dubey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116736/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 7:14 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Bugs: 330115
>     http://bugs.kde.org/show_bug.cgi?id=330115
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Fixed the bug. Applied a new condition. Tested on local system.
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediaplayer/MusicStats.qml 178a37d 
>   mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
> 
> Diff: https://git.reviewboard.kde.org/r/116736/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Atul Dubey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140311/401c09d7/attachment.html>