Review Request 116731: Bug Fix for Music Stats Labels (Bug 331882)

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116731/#review52668
-----------------------------------------------------------


Thanks for the patch. However, I am not sure we should have these labels because of two reasons -

1. We are already short of real estate on the screen, there is already less space left at times to show full names of songs, album etc
2. People usually know what is a name of an artist and what is the name of an album, so there isn't really a need of these labels

So, I personally won't want this to go in. However, if you think this makes sense, you can wait for what others have to say.

- Shantanu Tushar


On March 11, 2014, 5:21 p.m., Atul Dubey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116731/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 5:21 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Bugs: 331882
>     http://bugs.kde.org/show_bug.cgi?id=331882
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Created the labels for the details like artist, album, year etc... We can Browse any music file and we get all the details with orange-colored labels...
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediaplayer/MusicStats.qml 178a37d 
> 
> Diff: https://git.reviewboard.kde.org/r/116731/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Atul Dubey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140311/341d6645/attachment.html>