Review Request 116703: Improve section heading

[Thomas Lübking]

> On March 11, 2014, 8:28 a.m., Thomas Pfeiffer wrote:
> > Fine from the UI side, I can't say anything about the code itself
> 
> Christoph Feck wrote:
>     It feels a bit odd that the space between the two text lines within each item is larger than the space between two text lines from adjacent items.
> 
> Martin Gräßlin wrote:
>     yes, will also address that problem in another review request. It ignored my attempts with anchor margins so far.
> 
> Thomas Lübking wrote:
>     What about padding the "header" as well (aligned to the labels, not the checkboxes) as it's more like a separator?
> 
> Martin Gräßlin wrote:
>     > aligned to the labels, not the checkboxes
>     
>     I'm not sure whether I can get the position properly. The SectionDelegate doesn't see the ItemDelegats and vice versa.
> 
> Thomas Lübking wrote:
>     Evtl. we could "resort" to center alignment?
> 
> Martin Gräßlin wrote:
>     The "old" implementation doesn't use center. So just for the fun: http://paste.opensuse.org/22934042
>     
>     Given that we don't have the separator lines like in the old implementation I think that looks better.

Agreed. It nicely visually separates the group w/o additional space waste (by padding the text on the left and the buttons on the right)
I'd prefer this (unless someone vetos ;-)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116703/#review52618
-----------------------------------------------------------


On March 11, 2014, 8:08 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116703/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 8:08 a.m.)
> 
> 
> Review request for kwin, Plasma and Thomas Pfeiffer.
> 
> 
> Repository: kwin-compositing-kcm
> 
> 
> Description
> -------
> 
> Improve section heading
> 
> Using spacing around the header and no hardcoded color by using
> KColorscheme to get the base color and use the same alpha modulation
> as KCategoryDrawer.
> 
> 
> Diffs
> -----
> 
>   model.h 54b28c0ac642c1792e3b8dee644b229a3a663ad6 
>   qml/EffectView.qml e935089de810aad18f610ab08d2d7d7016e689f6 
> 
> Diff: https://git.reviewboard.kde.org/r/116703/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> New Category header
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/11/f21cff8d-9e23-474e-955f-10c508c12c06__kwineffects.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140311/69ce0724/attachment.html>