Review Request 116703: Improve section heading
Thomas Pfeiffer
colomar at autistici.org
Tue Mar 11 08:28:17 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116703/#review52618
-----------------------------------------------------------
Ship it!
Fine from the UI side, I can't say anything about the code itself
- Thomas Pfeiffer
On March 11, 2014, 8:08 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116703/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 8:08 a.m.)
>
>
> Review request for kwin, Plasma and Thomas Pfeiffer.
>
>
> Repository: kwin-compositing-kcm
>
>
> Description
> -------
>
> Improve section heading
>
> Using spacing around the header and no hardcoded color by using
> KColorscheme to get the base color and use the same alpha modulation
> as KCategoryDrawer.
>
>
> Diffs
> -----
>
> model.h 54b28c0ac642c1792e3b8dee644b229a3a663ad6
> qml/EffectView.qml e935089de810aad18f610ab08d2d7d7016e689f6
>
> Diff: https://git.reviewboard.kde.org/r/116703/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> New Category header
> https://git.reviewboard.kde.org/media/uploaded/files/2014/03/11/f21cff8d-9e23-474e-955f-10c508c12c06__kwineffects.png
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140311/7d90d7c8/attachment.html>
More information about the Plasma-devel
mailing list