Review Request 116674: Fix for "Bug 331888 - Playing media when searching, often plays the wrong media"

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116674/#review52557
-----------------------------------------------------------


Works fine for me, other than the following nitpick. As you said you're experiencing random bugs, you should wait for one more person to review before pushing this.


mediaelements/playlist/Playlist.qml
<https://git.reviewboard.kde.org/r/116674/#comment37131>

    ListView.Contain seems to work better actually. Center has a problem if you click on something without filtering, the view scrolls without any reason.


- Shantanu Tushar


On March 10, 2014, 3:51 p.m., Ashish Madeti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116674/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 3:51 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Bugs: 331888
>     http://bugs.kde.org/show_bug.cgi?id=331888
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Playing media while searching, often plays the wrong media.
> 
> 
> Diffs
> -----
> 
>   libs/mediacenter/filterplaylistmodel.h 19688af 
>   libs/mediacenter/filterplaylistmodel.cpp ff546f8 
>   libs/mediacenter/playlistmodel.h 52050fb 
>   mediaelements/playlist/Playlist.qml 0e87471 
> 
> Diff: https://git.reviewboard.kde.org/r/116674/diff/
> 
> 
> Testing
> -------
> 
> Played a media when search string was not empty.
> Correct media is playing.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140310/51144df0/attachment.html>