Review Request 116674: Fix for "Bug 331888 - Playing media when searching, often plays the wrong media"
Shantanu Tushar
shantanu at kde.org
Mon Mar 10 15:13:21 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116674/#review52555
-----------------------------------------------------------
You don't really need to add this method, you can just use the currentIndex properly of the model and whenever that changes, just positionViewAtIndex to Center on it.
- Shantanu Tushar
On March 9, 2014, 6:19 p.m., Ashish Madeti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116674/
> -----------------------------------------------------------
>
> (Updated March 9, 2014, 6:19 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
>
>
> Bugs: 331888
> http://bugs.kde.org/show_bug.cgi?id=331888
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Playing media while searching, often plays the wrong media.
>
>
> Diffs
> -----
>
> libs/mediacenter/filterplaylistmodel.h 19688af
> libs/mediacenter/filterplaylistmodel.cpp ff546f8
> libs/mediacenter/playlistmodel.h 52050fb
> mediaelements/playlist/Playlist.qml 0e87471
>
> Diff: https://git.reviewboard.kde.org/r/116674/diff/
>
>
> Testing
> -------
>
> Played a media when search string was not empty.
> Correct media is playing.
>
>
> Thanks,
>
> Ashish Madeti
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140310/ba4bcbb0/attachment.html>
More information about the Plasma-devel
mailing list