Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

[Thomas Lübking]

> On March 10, 2014, 9:20 a.m., Thomas Lübking wrote:
> > File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png
> > <https://git.reviewboard.kde.org/r/116648/#fcomment186>
> >
> >     Scale method and vsync are backend dependent, so i'd move this below the two (resp. them right below the backend)
> 
> Martin Gräßlin wrote:
>     I gave a try to most of the suggestions: http://paste.opensuse.org/69069300
>     
>     I'm not completely convinced that this is better or worse than than the one before.

The left aligned checkboxes on the bottom kinda suck (at least i don't like this in formlayouts)
-> 

Expert: [ ] Unredirect fullscreen windows // yes, techi to scare ppl. away ;-)
Experimental: [ ] Color correction


> On March 10, 2014, 9:20 a.m., Thomas Lübking wrote:
> > File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png
> > <https://git.reviewboard.kde.org/r/116648/#fcomment187>
> >
> >     Would this rather belong into the FX kcm?
> 
> Thomas Pfeiffer wrote:
>     The "Enable Desktop Effects on Startup" option is one which several people have suggested should be in the Effects kcm.
>     I talked to Martin about this and he suggested that people without advanced technical understanding would be better off just leaving it unchanged, and that this only affects Xorg anyway.
>     Since I lack the technical knowledge to really judge whether this makes sense, I just trust him about it.
>     On the other hand, it would be convenient for people who just don't want any effects at all to be able to turn them all off with a single click instead of having to turn each one off individually. This should not be done with a separate checkbox which "normal" people don't understand anyway, though, but with a global checkbox above the other checkboxes which can check or uncheck all other checkboxes.
> 
> Martin Gräßlin wrote:
>     Could be done, but I'm not sure how it would fit in the UI at all. It's now basically just the Effects list view and allows to just configure each of the effects independently. Thus I see it as a per-effect config interface and think that such a global option doesn't fit.
>     
>     At least it's trivial to change. Will give a try to the suggested changes and upload a new screenshot.

FTR, this was about the animationspeed slider, not the "enable on startup" checkbox.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116648/#review52495
-----------------------------------------------------------


On March 10, 2014, 9:03 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116648/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 9:03 a.m.)
> 
> 
> Review request for kwin, Plasma and Antonis Tsiapaliokas.
> 
> 
> Repository: kwin-compositing-kcm
> 
> 
> Description
> -------
> 
> Split into one KCM for Desktop Effects and one for Compositing
> 
> Let's try getting the KCM a little bit less scary by properly
> hiding everything the user doesn't have to care about. The prominent
> desktop effects KCM only contains the list of all the effects which
> can be configured and nothing else. Only exception is the disabled
> check after failed GL to make this easier for the user.
> 
> All the "advanced" settings are moved into a new KCM called
> "Compositing" which is put under the hardware component in
> systemsettings. This contains all advanced settings including
> * whether compositing is enabled at all
> * backend
> * animation speeed
> * scale filter
> * unredirect fullscreen
> * color correction
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d70672f3937fb44240c2c2d8e2a8d90c67890e2a 
>   kcmkwineffects.desktop PRE-CREATION 
>   kwincompositing.desktop 88ecf46b393df947d6b59ce53c924a82fc65756a 
>   main.cpp 5c68722961be9b8a0a48f3221df7c033ba3cf946 
>   model.h 2efa2a9df63ee7f7ec483df004ff9530fdc0f852 
>   model.cpp 2b25fe04ccacf0fb719956b1b5fa0267611747e6 
>   qml/CompositingView.qml PRE-CREATION 
>   qml/EffectView.qml c1a66dfa41409ba04c4cf4ddded3d95bb4bfaef2 
>   qml/OpenGLErrorView.qml PRE-CREATION 
>   qml/main-compositing.qml PRE-CREATION 
>   qml/main.qml d22dd08da529df938d99ff9d43f52f7b33a7f2d3 
> 
> Diff: https://git.reviewboard.kde.org/r/116648/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> New advanced compositing KCM
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e20bc5a1-c873-497a-b005-efb6b58da7c5__kcmcompositing.png
> New effects KCM
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/0d6c955e-fdd2-4a84-91b4-53959f2745f5__kcmeffects.png
> Effects KCM with GHNS button
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/f467b643-5341-4cfe-8282-eeea93bc98e5__kcmeffects.png
> Latest kcmcompositing screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/10/70df036e-f3ad-455d-a323-c8f36220afd4__kcmcompositing.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140310/33071bbb/attachment.html>