Review Request 116674: Fix for "Bug 331888 - Playing media when searching, often plays the wrong media"

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116674/#review52457
-----------------------------------------------------------


This does play the right media, good job. However, its still a bit confusing from the UI bits as if you click a song in the filtered list, the filter gets reset (expected), but the currently playing song is nowhere in the view, you'll have to scroll and manually find it. It will be nice if you can make it automatic as part of this.

- Shantanu Tushar


On March 9, 2014, 5:01 p.m., Ashish Madeti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116674/
> -----------------------------------------------------------
> 
> (Updated March 9, 2014, 5:01 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Bugs: 331888
>     http://bugs.kde.org/show_bug.cgi?id=331888
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Playing media while searching, often plays the wrong media.
> 
> 
> Diffs
> -----
> 
>   mediaelements/playlist/Playlist.qml 0e87471 
>   libs/mediacenter/playlistmodel.h 52050fb 
>   libs/mediacenter/filterplaylistmodel.h 19688af 
>   libs/mediacenter/filterplaylistmodel.cpp ff546f8 
> 
> Diff: https://git.reviewboard.kde.org/r/116674/diff/
> 
> 
> Testing
> -------
> 
> Played a media when search string was not empty.
> Correct media is playing.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140309/5cd4e9fe/attachment.html>