Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

[Ashish Madeti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116656/
-----------------------------------------------------------

(Updated March 9, 2014, 5:20 a.m.)


Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Changes
-------

Added a remove function to the FilterModel itself, which will delete from source model after mapping the index to source.


Bugs: 331820
    http://bugs.kde.org/show_bug.cgi?id=331820


Repository: plasma-mediacenter


Description
-------

When you delete a media from playlist while searching, often some other media gets deleted.


Diffs (updated)
-----

  mediaelements/playlist/PlaylistDelegate.qml 644bfd0 
  mediaelements/playlist/Playlist.qml dbca104 
  libs/mediacenter/filterplaylistmodel.cpp e6f7053 
  libs/mediacenter/filterplaylistmodel.h aa1284b 

Diff: https://git.reviewboard.kde.org/r/116656/diff/


Testing
-------

Deleted some media, when filter text was not empty. Now, the correct media is getting deleted from the playlist.


Thanks,

Ashish Madeti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140309/7571f1ae/attachment.html>