Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

Jens Reuterberg jens at ohyran.se
Fri Mar 7 12:07:06 UTC 2014


Sry for perhaps breaking etiquette with review requests. The 
KCM are at this moment a hot topic and one of the many issues 
is fragmentation vs merging of subject.

The main issue is that the settings are, as it is, an extremely 
hostile area for new users. The sorting is arbitrary but justified 
through technical reasons (Like having two separate 
appearance segments) and the idea of splitting them up into 
an "advanced" section and a "basic" section has been met with, 
perhaps to some, healthy skepticism ;)

But this is just such a split. Having a compositing and desktop 
effect as two separate areas so that one of them, the more 
technical section would be held isolated from a user only 
makes sense if it actually signals this shift:

Having two titles, one "Desktop Effects" and one "Compositing" 
doesn't tell the user anything except "darn it they split it into 
two things again for no reason".

If they have to be split into two, I suggest renaming them into 
something more correct instead of something precise - like
"Eye candy" and "Compositing KWM system", one being 
extremely childish and fancyful and the other unecessarily 
technical and complex. Signalling accessability with one, and 
distance with the other.

On Friday 07 March 2014 09.20.15 Martin Gräßlin wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116648/
> -----------------------------------------------------------
> 
> Review request for kwin, Plasma and Antonis Tsiapaliokas.
> 
> 
> Repository: kwin-compositing-kcm
> 
> 
> Description
> -------
> 
> Split into one KCM for Desktop Effects and one for 
Compositing
> 
> Let's try getting the KCM a little bit less scary by properly
> hiding everything the user doesn't have to care about. The 
prominent
> desktop effects KCM only contains the list of all the effects 
which
> can be configured and nothing else. Only exception is the 
disabled
> check after failed GL to make this easier for the user.
> 
> All the "advanced" settings are moved into a new KCM called
> "Compositing" which is put under the hardware component in
> systemsettings. This contains all advanced settings including
> * whether compositing is enabled at all
> * backend
> * animation speeed
> * scale filter
> * unredirect fullscreen
> * color correction
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 
90d27a02f691d500662754658518d1e99cfbc022
>   kcmkwineffects.desktop PRE-CREATION
>   kwincompositing.desktop 
88ecf46b393df947d6b59ce53c924a82fc65756a
>   main.cpp 5c68722961be9b8a0a48f3221df7c033ba3cf946
>   model.h c047677fed50606b194049734afeb87cbcc385cb
>   model.cpp 2b25fe04ccacf0fb719956b1b5fa0267611747e6
>   qml/CompositingView.qml PRE-CREATION
>   qml/EffectView.qml 
1c9d3a6d292c589bd4ab31d4c6071f2b4ff658c3
>   qml/main-compositing.qml PRE-CREATION
>   qml/main.qml 
d22dd08da529df938d99ff9d43f52f7b33a7f2d3
> 
> Diff: https://git.reviewboard.kde.org/r/116648/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> New advanced compositing KCM
>  
> 
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e20bc5a1-c8
> 73-497a-b005-efb6b58da7c5__kcmcompositing.png New 
effects KCM
>  
> 
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/0d6c955e-fd
> d2-4a84-91b4-53959f2745f5__kcmeffects.png
> 
> 
> Thanks,
> 
> Martin Gräßlin



More information about the Plasma-devel mailing list