Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116648/
-----------------------------------------------------------

(Updated March 7, 2014, 12:10 p.m.)


Review request for kwin, Plasma and Antonis Tsiapaliokas.


Changes
-------

moved the OpenGL broken error view into an own QML file to have less code duplication and uses a column layout as suggested.

In addition the qdebug include is dropped and one spacing issue is fixed.

All the layouting issues of the effect view are not addressed as that's topic for another review.


Repository: kwin-compositing-kcm


Description
-------

Split into one KCM for Desktop Effects and one for Compositing

Let's try getting the KCM a little bit less scary by properly
hiding everything the user doesn't have to care about. The prominent
desktop effects KCM only contains the list of all the effects which
can be configured and nothing else. Only exception is the disabled
check after failed GL to make this easier for the user.

All the "advanced" settings are moved into a new KCM called
"Compositing" which is put under the hardware component in
systemsettings. This contains all advanced settings including
* whether compositing is enabled at all
* backend
* animation speeed
* scale filter
* unredirect fullscreen
* color correction


Diffs (updated)
-----

  CMakeLists.txt 90d27a02f691d500662754658518d1e99cfbc022 
  kcmkwineffects.desktop PRE-CREATION 
  kwincompositing.desktop 88ecf46b393df947d6b59ce53c924a82fc65756a 
  main.cpp 5c68722961be9b8a0a48f3221df7c033ba3cf946 
  model.h c047677fed50606b194049734afeb87cbcc385cb 
  model.cpp 2b25fe04ccacf0fb719956b1b5fa0267611747e6 
  qml/CompositingView.qml PRE-CREATION 
  qml/EffectView.qml 1c9d3a6d292c589bd4ab31d4c6071f2b4ff658c3 
  qml/OpenGLErrorView.qml PRE-CREATION 
  qml/main-compositing.qml PRE-CREATION 
  qml/main.qml d22dd08da529df938d99ff9d43f52f7b33a7f2d3 

Diff: https://git.reviewboard.kde.org/r/116648/diff/


Testing
-------


File Attachments
----------------

New advanced compositing KCM
  https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e20bc5a1-c873-497a-b005-efb6b58da7c5__kcmcompositing.png
New effects KCM
  https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/0d6c955e-fdd2-4a84-91b4-53959f2745f5__kcmeffects.png


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140307/2929ab60/attachment.html>