Review Request 116633: Change default font settings to Oxygen font

[Aleix Pol Gonzalez]

> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote:
> > How will this work with other non KDE apps (like Chrome), will they simply pickup the Oxygen font?
> > 
> > I'm asking because fonts are working just fine now. If i open a GTK app in KDE it shows the fonts in the same manner as a KDE app would show them. That is consistent and quite likable :)
> 
> Sebastian Kügler wrote:
>     They won't pick up the font. Nothing we can do about that in Plasma. Needs the distro or the Chrome developers to do it. The Oxygen Widget style for GTK could probably pick it up, though.
>     
>     This is unrelated to this patch, however.
> 
> Mark Gaiser wrote:
>     Well, if this patch gives the user a broken consistency (Chrome is being used by lots of people, including KDE folks) then i think it might be best to keep the defaults consistent and keep it at sans-serif.
>     
>     That would at least keep the default consistent.
>     Another approach might be (don't know if that's done already) to generate a local user font.conf which changes the default sans-serif font to whatever font is set in KDE's font settings.
>     
>     Note: Chrome is just a sane example here. Others would be gparted, firefox, <fill in any gtk app>
> 
> Martin Gräßlin wrote:
>     @Mark: well it's orthogonal to this change. We need to start somewhere the transition. If we block the first patch because it introduces inconsistancies, we will never be able to adress it. Thus I think it's the right approach to start with the what we have control over.
> 
> Aleix Pol Gonzalez wrote:
>     @Mark: Nobody assures Chrome will be using "Sans Serif" either, this patch doesn't make a difference in this regard...
> 
> Mark Gaiser wrote:
>     @Martin, @Aleix; To be clear, I'm not against this change at all. I'm only against the result it will have. Sure, you need to start somewhere. In this case that would be assuring that all applications follow the font settings that are in kde's font settings. How one should tackle that, i don't know. I guess it's possible with a local fonts.conf file.
>     
>     @Aleix not a strong argument. GUI interfaces almost always use the default font settings. My exact point is that those defaults _won't_ change for GTK apps with this patch.
> 
> Àlex Fiestas wrote:
>     Well supporting gtk app's is as simple as writing the configuration file like or kcm-gtk-style does. If chromium is not reading that and rather using their own config file (which I doubt) then it would be their bug, not ours.
>     
>     Also, imho we should ask KDE/PLasma distributions to set this settings by default distro-wise.
> 
> Àlex Fiestas wrote:
>     Just to make my point clear, I'm not against this review but I think it should be followed by another one configuring other toolkits fonts :)
> 
> Sebastian Kügler wrote:
>     Yes, it makes sense to enforce the font setting also in other places. Our GTK KCM hasn't been ported yet, it seems, but once it is ported, we should definitely make sure it uses the Oxygen font as well (if the Oxygen GTK style doesn't already do so).
>     
>     You're listed as maintainer for the frameworksintegration repo, so if you think the code in this review is OK, please hit ship it. :)

The GTK kcm will suggest as a default whatever the QPA suggests, but then you have to go in the kcm at least once.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52255
-----------------------------------------------------------


On March 6, 2014, 4:36 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 4:36 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file called OxygenFontConfig.cmake, which is used for checking the dependency is available.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e249554 
>   src/platformtheme/kfontsettingsdata.cpp 62990ce 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> -------
> 
> Started kate without a kdeglobals file being present, fonts are picked up correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140307/eed49160/attachment.html>