Review Request 116633: Change default font settings to Oxygen font
Martin Gräßlin
mgraesslin at kde.org
Thu Mar 6 16:24:08 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52278
-----------------------------------------------------------
modulo the small issue below +1 from my side
CMakeLists.txt
<https://git.reviewboard.kde.org/r/116633/#comment37034>
DESCRIPTION and URL should go into the set_package_properties in the Config.cmake - at least I have been told so in other reviews ;-)
- Martin Gräßlin
On March 6, 2014, 4:49 p.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 4:49 p.m.)
>
>
> Review request for Plasma and Àlex Fiestas.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> Change default font settings to Oxygen font
>
>
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file called OxygenFontConfig.cmake, which is used for checking the dependency is available.
>
>
> Diffs
> -----
>
> CMakeLists.txt e249554
> src/platformtheme/kfontsettingsdata.cpp 62990ce
>
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
>
>
> Testing
> -------
>
> Started kate without a kdeglobals file being present, fonts are picked up correctly.
>
>
> Thanks,
>
> Sebastian Kügler
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140306/ac04174e/attachment.html>
More information about the Plasma-devel
mailing list