Review Request 116633: Change default font settings to Oxygen font

Martin Gräßlin mgraesslin at kde.org
Thu Mar 6 16:22:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52276
-----------------------------------------------------------


> will push that once this patch is through review

shouldn't it be the other way around? How would anyone be able to compile test your review without those files in the oxygen fonts repo?

- Martin Gräßlin


On March 6, 2014, 4:49 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 4:49 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file called OxygenFontConfig.cmake, which is used for checking the dependency is available.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e249554 
>   src/platformtheme/kfontsettingsdata.cpp 62990ce 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> -------
> 
> Started kate without a kdeglobals file being present, fonts are picked up correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140306/be533922/attachment.html>


More information about the Plasma-devel mailing list