Review Request 116627: EGL/X11 backend for WindowThumbnail QQuickItem

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116627/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-framework


Description
-------

EGL/X11 backend for WindowThumbnail QQuickItem

Introduces a new optional dependency to EGL. If EGL is found the
WindowThumbnail gets compiled with EGL support. The EGL support is
unlike Qt's XCB plugin not mutual exclusive to the GLX backend, thus
it's possible to compile with EGL and GLX at the same time.
By that this implementation is prepared for the case that Qt supports
EGL or GLX through runtime selection.

In practice EGL support is only useful if Qt is compiled with GLESv2.
In that case the corebindingsplugin gets linked against Qt5::Gui_GLESv2
to get the dependency to GLES.

The implementation makes use of the EGL_KHR_image extension
(or EGL_KHR_image_base and EGL_KHR_Image_pixmap) and
the GL_OES_EGL_image extension to bind the X pixmap to an EGLImageKHR.


Diffs
-----

  CMakeLists.txt 357aaa9bc2faa88b9d0a61cf0cc9ac9e71ededbe 
  src/declarativeimports/core/CMakeLists.txt 97e9283030e3b3771433381422fcfd809a53239a 
  src/declarativeimports/core/windowthumbnail.h 1d45953938326e9cba5c1365d8c4b3df7a840e71 
  src/declarativeimports/core/windowthumbnail.cpp b96d939b2384ea245e190a401c427f0c21112994 
  src/plasma/config-plasma.h.cmake c1aa75db71892ff6e5043129cdef27740e562f0e 

Diff: https://git.reviewboard.kde.org/r/116627/diff/


Testing
-------

plasmoidviewer -a org.kde.example.windowthumbnails in a GLES build.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140306/c7eac355/attachment.html>