Review Request 116613: Fix dis/connects in PanelView

Marco Martin notmart at gmail.com
Wed Mar 5 13:09:55 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116613/#review52074
-----------------------------------------------------------

Ship it!


ouch, i missed it when the signal was renamed :/
that's what one gets for using the old connect syntax ;) (maybe while you're at it.. new syntax?)

- Marco Martin


On March 5, 2014, 12:45 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116613/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 12:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> I was getting a warning that they didn't exist, changed for the most similar thing.
> 
> 
> Diffs
> -----
> 
>   src/shell/panelview.cpp 949f6fa 
> 
> Diff: https://git.reviewboard.kde.org/r/116613/diff/
> 
> 
> Testing
> -------
> 
> I don't get a warning anymore.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140305/2e2030f8/attachment-0001.html>


More information about the Plasma-devel mailing list