Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

[Kevin Ottens]

> On Feb. 26, 2014, 9:41 a.m., Kevin Krammer wrote:
> > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 78
> > <https://git.reviewboard.kde.org/r/116075/diff/1/?file=246242#file246242line78>
> >
> >     I see lambdas being using later on, in which case this looks like a candidate for std::find_if() with a lambda predicate

Good catch. Indeed, what about switching to find_if here?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review50909
-----------------------------------------------------------


On March 3, 2014, 8:36 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 8:36 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Add menu support to KDEPlatformSystemTrayIcon
> 
> Uses new QPA API which got introduced in Qt 5.3.
> 
> Provide an implementation for QPlatformSystemTrayIcon
> 
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
> 
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
> 
> This is adressed in Qt 5.3 which extends the QPA API.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformtheme.cpp a5d86c27385447b7744cb8bca0cf65889872fb0b 
>   autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
>   src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
>   src/platformtheme/kdeplatformtheme.h f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
> 
> 
> Testing
> -------
> 
> Using systray from qtbase/examples/widgets/desktop/systray
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140304/5c7ca125/attachment.html>