Review Request 116597: Remove unneeded signal from the plasma mediacenter picasa backend
Shantanu Tushar
shantanu at kde.org
Tue Mar 4 16:18:45 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116597/#review51903
-----------------------------------------------------------
Ship it!
Ship It!
- Shantanu Tushar
On March 4, 2014, 4:09 p.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116597/
> -----------------------------------------------------------
>
> (Updated March 4, 2014, 4:09 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> This signal is never emitted and never used and pulling extra plasma dep in the picasa backend. It will depend upon Plasma anyway but at runtime.
>
>
> Diffs
> -----
>
> browsingbackends/onlineservices/picasa/picasamodel.h 4a1ca4a
>
> Diff: https://git.reviewboard.kde.org/r/116597/diff/
>
>
> Testing
> -------
>
> Yeah, works.
>
> - compiles
> - builds
> - links
> - works
>
>
> Thanks,
>
> Bhushan Shah
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140304/de6dcc11/attachment.html>
More information about the Plasma-devel
mailing list