Review Request 115952: [kinfocenter] Add support for OpenGL running on Wayland

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115952/#review51852
-----------------------------------------------------------


This review has been submitted with commit 8e9a61cfed4d29707781a861f663f1cdf421c8b2 by Martin Gräßlin to branch master.

- Commit Hook


On Feb. 22, 2014, 10:34 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115952/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2014, 10:34 a.m.)
> 
> 
> Review request for Plasma and David Stephen Hubner.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> [kinfocenter] Add support for OpenGL running on Wayland
> 
> The X11 specific code is only executed on xcb platform. For detecting
> OpenGL on Wayland we don't do the native calls ourself, but use Qt
> functionality. We know that on Wayland Qt will use egl, so to simplify
> we can just use an QOpenGLContext. That code would also work for xcb,
> but Qt uses either glx or egl compile time switched, so it's easier to
> just keep the existing and working glx and egl implementation for X11.
> 
> As Qt makes it easy to request both core and compatibility profile we
> try all of that:
> * normal (nothing specified)
> * core
> * compatibility
> 
> The X11 code should also be extended in that direction. Unfortunately
> I couldn't test it as the mesa version I'm currently running is only
> providing OpenGL 3.0.
> 
> 
> Diffs
> -----
> 
>   kinfocenter/Modules/opengl/opengl.cpp 601337f071452eca7a3add127e8e1ff1586bbef0 
> 
> Diff: https://git.reviewboard.kde.org/r/115952/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> OpenGL module on Wayland
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/02/22/49469470-c14a-4b76-b476-e291497452df__kinfocenter-gl-wayland.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140304/c16e5dd4/attachment.html>