Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the "Bug 322821 - Make volume controllable using mouse scroll "

[Rukshan Chathuranga]

> On March 3, 2014, 3:07 p.m., Shantanu Tushar wrote:
> > mediaelements/mediacontroller/MediaController.qml, lines 201-205
> > <https://git.reviewboard.kde.org/r/116517/diff/7/?file=251718#file251718line201>
> >
> >     why are you doing it like this now? This previous code was better-
> >     
> >     onReleased: volumeButton.checked = !volumeButton.checked

yes. 
But with this "onReleased: volumeButton.checked = !volumeButton.checked" i toggle the button state.
that why rechange to this way. i fix this.


- Rukshan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116517/#review51799
-----------------------------------------------------------


On March 3, 2014, 3:13 p.m., Rukshan Chathuranga wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116517/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 3:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Implement change volume on mouse wheel when top of the voulume icon.
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediacontroller/MediaController.qml 968c459 
> 
> Diff: https://git.reviewboard.kde.org/r/116517/diff/
> 
> 
> Testing
> -------
> 
> tested the function and not change the default controlling due to new changes.
> 
> 
> Thanks,
> 
> Rukshan Chathuranga
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140303/6407dd80/attachment.html>