Review Request 115989: [kinfocenter] Add new module for a Wayland Compositor
Sebastian Kügler
sebas at kde.org
Mon Mar 3 14:35:40 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115989/#review51795
-----------------------------------------------------------
Ship it!
looks sane to my limited understanding.
- Sebastian Kügler
On Feb. 24, 2014, 8:13 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115989/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 8:13 a.m.)
>
>
> Review request for Plasma and David Stephen Hubner.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> [kinfocenter] Add new module for a Wayland Compositor
>
> Inspired by the module for X-Server we have a new module for Wayland
> Compositors. The module introduces a new optional build dependency to
> wayland client libraries.
>
> Just like the X-Server module it talks to Wayland directly without the
> help of Qt. It connects to the registry and adds all reported
> interfaces to the tree widget. For outputs and seats it registers a
> listener to also include this information. For every output the
> information is appended, for a seat the capabilities are included.
>
> This approach should allow to add information about further interfaces
> if they provide interesting information in future.
>
>
> Diffs
> -----
>
> kinfocenter/Modules/base/CMakeLists.txt 5e05617fc8e6fbb174c33e81a62264311da8c040
> kinfocenter/Modules/base/config-infocenter.h.cmake abde2c5e8a5400cf1939ddd0cce1e1fff96acb9e
> kinfocenter/Modules/base/info_linux.cpp 3ca95c15a1d87245df118ffaea935d88200b3327
> kinfocenter/Modules/base/info_wayland.h PRE-CREATION
> kinfocenter/Modules/base/info_wayland.cpp PRE-CREATION
> kinfocenter/Modules/base/os_current.h b1c262f7f602bd6284ec6299e2b33cc0a056a41d
> kinfocenter/Modules/info/CMakeLists.txt 211c0cd17dd0b723eadc1cc0b1efdb24968355ba
> kinfocenter/Modules/info/main.cpp c07594c60e869d9d79b4ebb05a9d8a15389a15e5
> kinfocenter/Modules/info/wayland.desktop PRE-CREATION
> kinfocenter/Modules/pci/CMakeLists.txt 03382625fa77b67639029867f534728fcddf61e8
>
> Diff: https://git.reviewboard.kde.org/r/115989/diff/
>
>
> Testing
> -------
>
> Run against Weston and also with no Weston running.
>
>
> File Attachments
> ----------------
>
> Module in action
> https://git.reviewboard.kde.org/media/uploaded/files/2014/02/24/1a9c6709-4220-499b-962b-f43894800d7b__kinfocenter-wayland-module.png
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140303/cdb16a4e/attachment.html>
More information about the Plasma-devel
mailing list