Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the "Bug 322821 - Make volume controllable using mouse scroll "

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116517/#review51430
-----------------------------------------------------------


I've got good news and bad news. The good news is, the wheel works perfect!

The bad news is that the MouseEventListener eats up clicks and hence the volumeButton never gets clicked which then means that you won't be able to show the volume slider. Hint to the solution lies in the order in which Qt delivers events (like mouse event in this case). Try if you can figure it out :)

- Shantanu Tushar


On March 1, 2014, 12:42 p.m., Rukshan Chathuranga wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116517/
> -----------------------------------------------------------
> 
> (Updated March 1, 2014, 12:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Implement change volume on mouse wheel when top of the voulume icon.
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediacontroller/MediaController.qml 968c459 
> 
> Diff: https://git.reviewboard.kde.org/r/116517/diff/
> 
> 
> Testing
> -------
> 
> tested the function and not change the default controlling due to new changes.
> 
> 
> Thanks,
> 
> Rukshan Chathuranga
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140301/ee3d6a47/attachment.html>