Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the "Bug 322821 - Make volume controllable using mouse scroll "
Rukshan Chathuranga
rcrukshan17 at gmail.com
Sat Mar 1 12:43:53 UTC 2014
> On March 1, 2014, 12:15 p.m., Shantanu Tushar wrote:
> > mediaelements/mediacontroller/MediaController.qml, lines 157-169
> > <https://git.reviewboard.kde.org/r/116517/diff/4/?file=251231#file251231line157>
> >
> > Please configure your editor to use 4 spaces instead of tabs. The next diff you upload should be spaces instead of tabs.
> > For more, read http://techbase.kde.org/Policies/Kdelibs_Coding_Style
Thans you for your help. i fixed it as you mention.
- Rukshan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116517/#review51423
-----------------------------------------------------------
On March 1, 2014, 12:42 p.m., Rukshan Chathuranga wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116517/
> -----------------------------------------------------------
>
> (Updated March 1, 2014, 12:42 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Implement change volume on mouse wheel when top of the voulume icon.
>
>
> Diffs
> -----
>
> mediaelements/mediacontroller/MediaController.qml 968c459
>
> Diff: https://git.reviewboard.kde.org/r/116517/diff/
>
>
> Testing
> -------
>
> tested the function and not change the default controlling due to new changes.
>
>
> Thanks,
>
> Rukshan Chathuranga
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140301/f4ffbc5c/attachment.html>
More information about the Plasma-devel
mailing list