Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the "Bug 322821 - Make volume controllable using mouse scroll "

Bhushan Shah bhush94 at gmail.com
Sat Mar 1 08:37:55 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116517/#review51408
-----------------------------------------------------------



mediaelements/mediacontroller/MediaController.qml
<https://git.reviewboard.kde.org/r/116517/#comment36204>

    PlasmaCore is already included.. ^



mediaelements/mediacontroller/MediaController.qml
<https://git.reviewboard.kde.org/r/116517/#comment36202>

    Remove White space here and at other parts. For future if you are using Kate,
    
    Set Settings > Configure Kate > Open/Save > Remove trailing spaces to on modified lines.



mediaelements/mediacontroller/MediaController.qml
<https://git.reviewboard.kde.org/r/116517/#comment36203>

    whitespace


- Bhushan Shah


On March 1, 2014, 12:57 p.m., Rukshan Chathuranga wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116517/
> -----------------------------------------------------------
> 
> (Updated March 1, 2014, 12:57 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Implement change volume on mouse wheel when top of the voulume icon.
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediacontroller/MediaController.qml 968c459 
> 
> Diff: https://git.reviewboard.kde.org/r/116517/diff/
> 
> 
> Testing
> -------
> 
> tested the function and not change the default controlling due to new changes.
> 
> 
> Thanks,
> 
> Rukshan Chathuranga
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140301/57966279/attachment.html>


More information about the Plasma-devel mailing list