Review Request 119027: Add basic application to load mediacenter shell

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119027/#review61261
-----------------------------------------------------------

Ship it!


Seems correct to me, apart a small detail


shells/application/pmccorona.cpp
<https://git.reviewboard.kde.org/r/119027/#comment42663>

    Here, you want to return the geometry of your (only) View as screenGeometry, or you won't see applets anywhere


- Marco Martin


On June 30, 2014, 9:52 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119027/
> -----------------------------------------------------------
> 
> (Updated June 30, 2014, 9:52 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Add a basic application to load mediacenter shell,
> 
> Which loads shell package
> Creates PlasmaQuick view to load Desktop.qml
> And adds one containment in corona
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f79e878 
>   shells/CMakeLists.txt 9877ee3 
>   shells/application/CMakeLists.txt PRE-CREATION 
>   shells/application/main.cpp PRE-CREATION 
>   shells/application/plasmaquick/view.h PRE-CREATION 
>   shells/application/pmccorona.h PRE-CREATION 
>   shells/application/pmccorona.cpp PRE-CREATION 
>   shells/application/pmcview.h PRE-CREATION 
>   shells/application/pmcview.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119027/diff/
> 
> 
> Testing
> -------
> 
> correctly works, containment is added to config file and restored on startup
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140630/c36dc344/attachment.html>