Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel
Vadim Zhukov
persgray at gmail.com
Mon Jun 30 09:17:57 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119025/
-----------------------------------------------------------
Review request for Plasma.
Repository: kimtoy
Description
-------
The ibus-panel can't build on OpenBSD because some required definitions obtained from pkgconfig file are not used. This happens due to the following reasons:
1. IBUS_DEFINITIONS is not used in ibus-panel/CMakeLists.txt
2. IBUS_DEFINITIONS is not saved in cache, and thus isn't available at compile time
This patch resolves both issues and makes ibus-panel compile on OpenBSD.
Diffs
-----
cmake/FindIBus.cmake 8250c49
ibus-panel/CMakeLists.txt 3a1ee49
Diff: https://git.reviewboard.kde.org/r/119025/diff/
Testing
-------
OpenBSD/i386-CURRENT, KDE 4.13 (it doesn't have kimtoy package, of course, but the code is same)
Thanks,
Vadim Zhukov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140630/55bcebee/attachment.html>
More information about the Plasma-devel
mailing list