Review Request 118977: KSMServer: Do not autostart files

[Vishesh Handa]

> On June 27, 2014, 3:10 p.m., Rohan Garg wrote:
> > I applied it locally here and krunner still starts up twice.
> 
> Rohan Garg wrote:
>     So, krunner starting twice is another bug in session management, but other apps like konsole only startup once after this patch
> 
> Marco Martin wrote:
>     is the rest up to date? now krunner should be started with autostart as the rest

It seems that KRunner was started twice cause it being restored by the session manager and being started. I'll change krunner to ignore session management. Something similar to this - https://git.reviewboard.kde.org/r/118978/diff/#index_header

This patch is still needed because apps are started twice (ignore session management)


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118977/#review61099
-----------------------------------------------------------


On June 27, 2014, 2:59 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118977/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 2:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335878
>     https://bugs.kde.org/show_bug.cgi?id=335878
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
>     KSMServer: Do not autostart files
> 
>     Currently KLauncher is responsible for starting all of the autostart
>     files. It intelligently starts only the files which should be started in
>     the KDE environment.
> 
>     Once this is done, KLauncher then decides to also start all the files
>     in the autostart folder, but does that without checking which should be
>     started. I'm not sure why both KSMServer and KLauncher are overlaping
>     and doing the same thing. But it seems that KLauncher is the correct
>     place to do this. Specially since ksmserver uses kioclient5 in order to
>     start the applications.
> 
>     BUG: 335878
> 
> 
> Diffs
> -----
> 
>   ksmserver/server.h 3d19118 
>   ksmserver/startup.cpp 11cc968 
> 
> Diff: https://git.reviewboard.kde.org/r/118977/diff/
> 
> 
> Testing
> -------
> 
> Applications are now only started once.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140627/a6fb8afc/attachment-0001.html>