Review Request 118937: DesktopView: Launch krunner on typing

David Edmundson david at davidedmundson.co.uk
Wed Jun 25 14:47:12 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118937/#review60959
-----------------------------------------------------------

Ship it!



shell/desktopview.cpp
<https://git.reviewboard.kde.org/r/118937/#comment42460>

    Add some documentation like
    
    /*
    When a key is pressed on desktop when nothing else is active forward the key to krunner
    */


- David Edmundson


On June 25, 2014, 2:38 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118937/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 2:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 336692
>     https://bugs.kde.org/show_bug.cgi?id=336692
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is consistent with the behaviour in Plasma 4.
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt ed1348f 
>   shell/desktopview.h 1cc5881 
>   shell/desktopview.cpp a0e08ad 
> 
> Diff: https://git.reviewboard.kde.org/r/118937/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140625/75d56cc9/attachment-0001.html>


More information about the Plasma-devel mailing list