Review Request 118933: PlasmaShell: Do not start krunner

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118933/#review60951
-----------------------------------------------------------


I like it.

- Aleix Pol Gonzalez


On June 25, 2014, 10:58 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118933/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 10:58 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
>     PlasmaShell: Do not start krunner
> 
>     Krunner is automatically started via an autostart file. We do not need plasma to
>     start it as well. Without this patch, krunner comes into focus each time
>     plasma is restarted since krunner is already running and executing it
>     then gives it focus.
> 
>     BUG: 336002
> 
> This patch depends on another patch in plasma-workspace/krunner which adds the krunner.desktop file -
> 
> commit 1b570623b1e8df93f20940654e160b35570172ac
> Author: Vishesh Handa <me at vhanda.in>
> Date:   Wed Jun 25 11:38:49 2014 +0200
> 
>     Add a KRunner autostart file
> 
> diff --git a/krunner/CMakeLists.txt b/krunner/CMakeLists.txt
> index 8e625b9..4197827 100644
> --- a/krunner/CMakeLists.txt
> +++ b/krunner/CMakeLists.txt
> @@ -35,6 +35,7 @@ target_link_libraries(krunner
>  
>  install(TARGETS krunner ${INSTALL_TARGETS_DEFAULT_ARGS})
>  install(FILES ${krunner_dbusAppXML} DESTINATION ${DBUS_INTERFACES_INSTALL_DIR} )
> +install(FILES krunner.desktop DESTINATION ${AUTOSTART_INSTALL_DIR})
>  
>  set(CMAKECONFIG_INSTALL_DIR "${CMAKECONFIG_INSTALL_PREFIX}/KRunnerAppDBusInterface")
>  ecm_configure_package_config_file(KRunnerAppDBusInterfaceConfig.cmake.in
> diff --git a/krunner/krunner.desktop b/krunner/krunner.desktop
> new file mode 100644
> index 0000000..2f1f6dc
> --- /dev/null
> +++ b/krunner/krunner.desktop
> @@ -0,0 +1,9 @@
> +[Desktop Entry]
> +Exec=krunner
> +Name=KRunner
> +OnlyShowIn=KDE;
> +Type=Application
> +X-DBUS-StartupType=Unique
> +X-DBUS-ServiceName=org.kde.krunner
> +X-KDE-StartupNotify=false
> +X-KDE-autostart-phase=0
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/loader.qml c1ac4a4 
> 
> Diff: https://git.reviewboard.kde.org/r/118933/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140625/96e1969f/attachment.html>