Review Request 118899: Remove unused dependencies.

Sebastian Kügler sebas at kde.org
Tue Jun 24 13:00:34 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118899/#review60899
-----------------------------------------------------------

Ship it!


Nice cleanup. Could you just delete the commented lines before committing (and while add it, perhaps fix the indentation a few lines down from the removed line)?

- Sebastian Kügler


On June 23, 2014, 2:44 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118899/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 2:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Threadweaver is unused. Akonadi, Boost, KdepimLibs, and QImageBlitz are used only by commented-out stuff so there's no point trying to find and report about it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4bfa2e93abfc6f8087693c363e5982fa862cf0fa 
>   wallpapers/image/CMakeLists.txt 32dbf310ce7c243a62e042c71f8b9de420048cd8 
> 
> Diff: https://git.reviewboard.kde.org/r/118899/diff/
> 
> 
> Testing
> -------
> 
> Inspected source. Builds.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140624/318edf48/attachment.html>


More information about the Plasma-devel mailing list