Review Request 118891: Folder view icon text background
Andrew Lake
jamboarder at gmail.com
Tue Jun 24 00:18:04 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/
-----------------------------------------------------------
(Updated June 24, 2014, 12:18 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Bugs: 335070
https://bugs.kde.org/show_bug.cgi?id=335070
Repository: plasma-desktop
Description
-------
Addresses lack of contrast of folderview containment icon text on certain backgrounds: Bug 335070
The color of the text background is just the complement of the icon label text with a 0.6 opacity applied.
Diffs
-----
containments/folder/package/contents/ui/ConfigIcons.qml 9f57900
containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04
Diff: https://git.reviewboard.kde.org/r/118891/diff/
Testing
-------
File Attachments
----------------
with latest changes showing it with selection background
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/58f07e42-08b4-480a-9c05-40195514edbf__icontextbackground2.png
Thanks,
Andrew Lake
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140624/25b85248/attachment.html>
More information about the Plasma-devel
mailing list