Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail
Commit Hook
null at kde.org
Mon Jun 23 17:59:20 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118886/#review60829
-----------------------------------------------------------
This review has been submitted with commit 347e073df39429bf1be804a2c3d32aad09b7f0ab by Kai Uwe Broulik to branch master.
- Commit Hook
On June 23, 2014, 5:39 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118886/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 5:39 p.m.)
>
>
> Review request for Plasma and Martin Gräßlin.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This adds paintedWidth and paintedHeight properties to PlasmaCore.WindowThumbnail which tells as how large the thumbnail, which is scaled keeping aspect ratio, actually is, similar to what QML Image does. This is will eventually allow the taskmanager to size its tooltips more appropriately.
>
> (Is it better to store m_paintedWidth and m_paintedHeight separately, or is the QSize thing I used ok?)
>
>
> Diffs
> -----
>
> src/declarativeimports/core/windowthumbnail.h 14fc44a
> src/declarativeimports/core/windowthumbnail.cpp b10f030
>
> Diff: https://git.reviewboard.kde.org/r/118886/diff/
>
>
> Testing
> -------
>
> Works, reports the actual size
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140623/77462ea6/attachment-0001.html>
More information about the Plasma-devel
mailing list