Review Request 118900: Improve dependencies.
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Jun 23 15:10:32 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118900/#review60808
-----------------------------------------------------------
CMakeLists.txt
<https://git.reviewboard.kde.org/r/118900/#comment42378>
If you want these to be optional, you can pass them in OPTIONAL_COMPONENTS, from the top find_package.
- Aleix Pol Gonzalez
On June 23, 2014, 3:07 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118900/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 3:07 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> KF5WebKit is only used if drkonqi is built with (optional) KF5XmlRpcClient. Qt5Concurrent is only required for tests.
>
>
> Diffs
> -----
>
> CMakeLists.txt 4bfa2e93abfc6f8087693c363e5982fa862cf0fa
> drkonqi/CMakeLists.txt 8224900e633c18f57ac3fbc7e5a77a8f5a34edb0
>
> Diff: https://git.reviewboard.kde.org/r/118900/diff/
>
>
> Testing
> -------
>
> Inspected source, builds, tests pass.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140623/d70e6a9c/attachment.html>
More information about the Plasma-devel
mailing list