Review Request 118896: Fix 2 data races in runnercontext, mention another one.

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118896/#review60766
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On June 23, 2014, 7:45 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118896/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 7:45 a.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Fix 2 data races in runnercontext, mention another one.
> 
> Found by helgrinding krunner. Turns out helgrind lacks support for
> QReadWriteLock, but reading the code still made me found these.
> 
> 
> Diffs
> -----
> 
>   plasma/private/runnerjobs.cpp 6a8a7710f95adba38cc56c2d59393bfa3b123185 
>   plasma/runnercontext.cpp abd6a4bc7fca2a0d05f27c6601b658ff552307b3 
> 
> Diff: https://git.reviewboard.kde.org/r/118896/diff/
> 
> 
> Testing
> -------
> 
> Typing various things into krunner.
> 
> The main crash is still there though: baloo or xapian isn't reentrant; but that's separate.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140623/8e504b69/attachment-0001.html>