Review Request 118891: Folder view icon text background

[Sebastian Kügler]

> On June 23, 2014, 9 a.m., Eike Hein wrote:
> > containments/folder/package/contents/ui/ItemDelegate.qml, line 121
> > <https://git.reviewboard.kde.org/r/118891/diff/2/?file=283777#file283777line121>
> >
> >     Are you sure you wanted to hard-code pixel values here instead of using hidpi scaling-aware margins? units.smallSpacing is effectively 2px right now at 'standard DPI'.

Yes, units.smallSpacing is the API to use here. I've recently changed it (last week), to be a bit bigger on higher DPI screens, so perhaps that helps?


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/#review60755
-----------------------------------------------------------


On June 23, 2014, 12:41 a.m., Andrew Lake wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118891/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 12:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335070
>     https://bugs.kde.org/show_bug.cgi?id=335070
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Addresses lack of contrast of folderview containment icon text on certain backgrounds: Bug 335070
> 
> The color of the text background is just the complement of the icon label text with a 0.6 opacity applied.
> 
> 
> Diffs
> -----
> 
>   containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
>   containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 
> 
> Diff: https://git.reviewboard.kde.org/r/118891/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Icon text background
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png
> 
> 
> Thanks,
> 
> Andrew Lake
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140623/117297bd/attachment.html>