Review Request 118637: [klipper] Port from XLib to XCB

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118637/
-----------------------------------------------------------

(Updated June 23, 2014, 6:35 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

[klipper] Port from XLib to XCB

This ports the workarounds using query pointer from XLib to XCB. At the
same time the build system is adjusted to only link against XCB and
Qt5::X11Extras if we are building for X11 and the define is taken from
config-X11.h instead of setting a define through CMakeLists.txt.

[klipper] Update apptime only on platform X11


[klipper] Use KWindowSystem for URLGrabber::isAvoidedWindow()

It had custom (and incorrect) code for reading the window class of the
active window. That's provided by KWindowSystem in a better way without
the need of having windowing system dependent code.


Diffs
-----

  klipper/CMakeLists.txt 999be53c5332048c90b98cbbd9b23fad72be2a4b 
  klipper/klipper.cpp 5e60a5ab0a31567545876888309b287ac9b4be35 
  klipper/urlgrabber.cpp 61425e0f88731575699429a5263b1306269d5ae1 

Diff: https://git.reviewboard.kde.org/r/118637/diff/


Testing
-------

* URL copied with actions enabled for normal window and browser
* selected word without lmb

* not tested: the OOo test case.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140623/c0d01844/attachment.html>