Review Request 118695: Don't set -DHAVE_X11 through target properties

Commit Hook null at kde.org
Mon Jun 23 06:33:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118695/#review60750
-----------------------------------------------------------


This review has been submitted with commit ca9be41cb8d4f459f9a31c92c1cc200b34e94f8e by Martin Gräßlin to branch master.

- Commit Hook


On June 12, 2014, 11:46 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118695/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 11:46 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Don't set -DHAVE_X11 through target properties
> 
> Include <config-X11.h> instead.
> 
> 
> Diffs
> -----
> 
>   kcms/colors/CMakeLists.txt 8f75d1dcee6f23c5c8378884a20befdc1139ea97 
>   kcms/fonts/CMakeLists.txt b4c237c8fd9a2acd89b1755b62dbadfafa239302 
>   kcms/fonts/fonts.cpp e57d745996925790123e716e47674c34801e02e0 
>   kcms/input/CMakeLists.txt 0baed093d2996a61ab8b02570ae072753368a697 
>   kcms/krdb/krdb.cpp cddfe24d0eed9d5e031b36b68a949601fc564131 
>   kcms/style/CMakeLists.txt 423241b8127491853d8afa75bb8b5d78c9009dca 
> 
> Diff: https://git.reviewboard.kde.org/r/118695/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140623/249c32b8/attachment.html>


More information about the Plasma-devel mailing list