Review Request 118891: Folder view icon text background
Andrew Lake
jamboarder at gmail.com
Mon Jun 23 00:41:06 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/
-----------------------------------------------------------
(Updated June 23, 2014, 12:41 a.m.)
Review request for Plasma.
Changes
-------
Updated to remove configuration of the icon text color and use theme colors when folderview is the desktop background.
Bugs: 335070
https://bugs.kde.org/show_bug.cgi?id=335070
Repository: plasma-desktop
Description
-------
Addresses lack of contrast of folderview containment icon text on certain backgrounds: Bug 335070
The color of the text background is just the complement of the icon label text with a 0.6 opacity applied.
Diffs (updated)
-----
containments/folder/package/contents/ui/ConfigIcons.qml 9f57900
containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04
Diff: https://git.reviewboard.kde.org/r/118891/diff/
Testing
-------
File Attachments (updated)
----------------
Icon text background
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png
Thanks,
Andrew Lake
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140623/8f1fe3cf/attachment.html>
More information about the Plasma-devel
mailing list