Review Request 118891: Folder view icon text background

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/#review60739
-----------------------------------------------------------


Not a +1 or -1. Just my preference for this.
- No background (aka, fully transparent) when nothing is selected.
- Selected items should show the background as in your screenshot.

Just my preference though :)

- Mark Gaiser


On June 22, 2014, 11:09 p.m., Andrew Lake wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118891/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 11:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335070
>     https://bugs.kde.org/show_bug.cgi?id=335070
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Addresses lack of contrast of folderview containment icon text on certain backgrounds: Bug 335070
> 
> The color of the text background is just the complement of the icon label text with a 0.6 opacity applied.
> 
> 
> Diffs
> -----
> 
>   containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 
> 
> Diff: https://git.reviewboard.kde.org/r/118891/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> After: Folderview as desktop
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/488f6ed9-462f-4ff4-b50c-c951c5a0de66__icontextbackground.png
> 
> 
> Thanks,
> 
> Andrew Lake
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140622/e45220b7/attachment.html>