Review Request 118876: Remove start in systemtray option from the kmenuedit.

[Eike Hein]

> On June 22, 2014, 12:25 p.m., Eike Hein wrote:
> > This might make sense as a temp measure, but what about porting ksystraycmd to KStatusNotifierItem? The KDE 4 version does see active use.
> 
> Bhushan Shah wrote:
>     Porting is not possible (removed), one have to write from scratch..

Just because code was removed from a repo doesn't mean it can't be restored and ported. That's why we use version control in the first place - so we don't lose past code. It might still make sense to start from scratch considering it's not complex and needs to change quite a bit by switching from KSystemTrayIcon, but to maintain compatibility with existing menu entries and scripts people have the command line interface of ksystraycmd should be recreated closely. I know of distros that have shipped such things in their default configs quite recently (e.g. Netrunner Linux).


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118876/#review60694
-----------------------------------------------------------


On June 22, 2014, 12:17 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118876/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 12:17 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: kmenuedit
> 
> 
> Description
> -------
> 
> This option uses ksystraycmd tool which is removed long ago
> 
> http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7
> 
> 
> Diffs
> -----
> 
>   basictab.h 9aa4c18 
>   basictab.cpp 6e3e086 
> 
> Diff: https://git.reviewboard.kde.org/r/118876/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140622/e79c7192/attachment-0001.html>