Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118851/#review60617
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/118851/#comment42289>

    This is not part of kf5, so shouldn't use KF5_VERSION. Instead, you may want a KDE_BASEAPPS_VERSION or something. This does not have to be at all related to the version of KF5 required.



CMakeLists.txt
<https://git.reviewboard.kde.org/r/118851/#comment42291>

    This should probably move to the lib/konq/CMakeLists.txt file.



CMakeLists.txt
<https://git.reviewboard.kde.org/r/118851/#comment42290>

    This should probably move the the dolphin/src/CMakeLists.txt file


- Alex Merry


On June 20, 2014, 5:53 p.m., Scarlett Clark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118851/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 5:53 p.m.)
> 
> 
> Review request for Dolphin, KDE Base Apps, Plasma, and Jonathan Riddell.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> I was ending up with so.SOVERSION when building this, so through some research I have come up with this patch to correct the issue.
> If there is a better way, please let me know.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a5588ea 
>   dolphin/src/CMakeLists.txt ce629fb 
>   lib/konq/CMakeLists.txt 6857e19 
> 
> Diff: https://git.reviewboard.kde.org/r/118851/diff/
> 
> 
> Testing
> -------
> 
> Builds fine on Kubuntu Utopic frameworks chroot. Results in the expected:
> libdolphinprivate.so
> libdolphinprivate.so.4.97.0
> libdolphinprivate.so.5
> libkdeinit5_dolphin.so
> libkonq.so
> libkonq.so.4.97.0
> libkonq.so.5
> 
> 
> Thanks,
> 
> Scarlett Clark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140620/49fd530c/attachment.html>