Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118849/#review60607
-----------------------------------------------------------

Ship it!


well, let's remove it for now

- Marco Martin


On June 20, 2014, 2:35 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118849/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 2:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
>     The popup dialog can currently never be resized, so it doesn't make
>     sense to record its height in a config file. Additionally, this also
>     causes problems when applet writers change the size of their plasmoid.
>     Since the old size is saved in the config file, it is shown with the old
>     dimensions instead of the new ones.
> 
> When we implement dialog resizing at that time we can propogate a signal which says that the applet has been manually resized and save it in a config file. Though even that could be buggy since the plasmoid could later be much smaller.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/appletquickitem.cpp a6e91f7 
>   src/plasmaquick/private/appletquickitem_p.h 8b8010a 
> 
> Diff: https://git.reviewboard.kde.org/r/118849/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140620/43190be8/attachment.html>