Review Request 118845: Apply some settings to KDE4 if possible

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118845/#review60596
-----------------------------------------------------------



kcms/krdb/krdb.cpp
<https://git.reviewboard.kde.org/r/118845/#comment42284>

    Given we have 2 configs open at once it would be easier to read to have the variable name indicate which file the group is from. i.e
    
    kde4generalGroup
    
    group & generalGroup doesn't tell us a lot.



kcms/krdb/krdb.cpp
<https://git.reviewboard.kde.org/r/118845/#comment42283>

    Is the goal of this patch is to have it so it syncs the settings the user just selected? If so, we don't want to be copying and saving a hardcoded "breeze".


- David Edmundson


On June 20, 2014, 11:22 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118845/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 11:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Some settings in kf5 applications are relatively safe to apply to kde4 as well, in order to keep applications feel "integrated"
> 
> this patch uses kde4migration to apply
> * colors
> * icons
> * fonts
> 
> when any of those is changed in systemsettings
> 
> 
> Diffs
> -----
> 
>   kcms/krdb/krdb.cpp cddfe24 
> 
> Diff: https://git.reviewboard.kde.org/r/118845/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140620/00c191f3/attachment-0001.html>