Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

Martin Klapetek martin.klapetek at gmail.com
Fri Jun 20 12:21:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118796/
-----------------------------------------------------------

(Updated June 20, 2014, 2:21 p.m.)


Review request for Plasma.


Changes
-------

* Fixed issues
* Added ability to load additional stuff from config file too


Repository: plasma-workspace


Description
-------

This prevents some apps to spam lots of notifications when all it needs is actually just one single notification.

Imagine you're switching songs in your playlist quickly and each song change sends new notification, but when
you get to the tenth song, you still see the notification from the 3rd song (because timeouts) and you don't
really care about all those songs changes still in the queue as you see it in the playlist anyway. 

So this patch limits certain apps to have only one single notification which is always updated. So far
Clementine and Spotify is there. Switching songs or changing playback status creates only one single popup.


Diffs (updated)
-----

  applets/notifications/package/contents/ui/NotificationPopup.qml d07ee32 
  applets/notifications/plugin/notificationshelper.cpp c5a1082 
  dataengines/notifications/notificationsengine.h df0d3ca 
  dataengines/notifications/notificationsengine.cpp aaf6079 

Diff: https://git.reviewboard.kde.org/r/118796/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140620/3ab69aef/attachment.html>


More information about the Plasma-devel mailing list