Review Request 118842: Add reset function to QImageItem image property

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118842/#review60578
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On June 20, 2014, 12:26 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118842/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 12:26 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Add reset function to QImageItem
> 
> This allows
> 
>     QImageItem {
>         image: undefined
>     }
> 
> without warnings. 
> 
> This is useful as otherwise it's impossible to unset a set QImageItem as QImage is uncreatable from within QML.
> 
> The immediate usage is to fix a bug in notifications where sometimes an image from a previous notification "leaks" into our current notification.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/qimageitem.h eef59bc 
>   src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp ed20605 
>   src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h eee8189 
>   src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp fcc66b5 
> 
> Diff: https://git.reviewboard.kde.org/r/118842/diff/
> 
> 
> Testing
> -------
> 
> Wrote small qml file, code had warning before, now it doesn't. 
> Images are still displayed if set.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140620/d9126a7e/attachment.html>