Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC last time"

[Shantanu Tushar Jha]

Hi Harish,

This is a known issue and is due to the fact that we don't save state while
switching the playlists. Maybe someone should report a bug if not already.


On Thu, Jun 19, 2014 at 10:44 PM, R.Harish Navnit <harishnavnit at gmail.com>
wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118767/
>
> On June 19th, 2014, 4:48 p.m. UTC, *Shantanu Tushar* wrote:
>
>   libs/mediacenter/playlistmodel.cpp
> <https://git.reviewboard.kde.org/r/118767/diff/2/?file=282626#file282626line56> (Diff
> revision 2)
>
> public:
>
>    56
>
>     d->playlistName = s.value("lastPlaylist", QVariant(DEFAULT_PLAYLIST_NAME)).toString();
>
>   The explicit call to QVariant should not be needed
>
>  I have just one issue in this. This is how I tested it.
>
> 1. Play a media from a playlist
> 2. Switch to another playlist
> 3. Return back to the playlist playing the current song.
> 4. Next and prev don't work.
> 5. Once the track finshes playing, the next track is not played. The mediacenter stops playing any media and I have to mannually choose a new media again.
>
> Imagine doing this over and over again once playlists are switched.
>
> Does anyone else face the same issue ?
>
>
> - R.Harish
>
> On June 19th, 2014, 4:30 p.m. UTC, Ashish Madeti wrote:
>   Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantanu
> Tushar, Sinny Kumari, and Sujith Haridasan.
> By Ashish Madeti.
>
> *Updated June 19, 2014, 4:30 p.m.*
>  *Bugs: * 328532 <http://bugs.kde.org/show_bug.cgi?id=328532>
>  *Repository: * plasma-mediacenter
> Description
>
> PMC didn't used to remember the playlist I was on the last time, when restarting it.
> Now it saves the "lastPlaylist" while closing in the settings, and when starting it loads the value of "lastPlaylist" in settings
>
>   Diffs
>
>    - libs/mediacenter/playlistmodel.cpp (dccaf52)
>
> View Diff <https://git.reviewboard.kde.org/r/118767/diff/>
>



-- 
Shantanu Tushar    (UTC +0530)
http://www.shantanutushar.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140619/120fcbc0/attachment.html>