Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC last time"
Shantanu Tushar
shantanu at kde.org
Thu Jun 19 16:48:49 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118767/#review60541
-----------------------------------------------------------
Ship it!
Seems to work correctly, just a minor nitpick and this can go in.
libs/mediacenter/playlistmodel.cpp
<https://git.reviewboard.kde.org/r/118767/#comment42270>
The explicit call to QVariant should not be needed
- Shantanu Tushar
On June 19, 2014, 4:30 p.m., Ashish Madeti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118767/
> -----------------------------------------------------------
>
> (Updated June 19, 2014, 4:30 p.m.)
>
>
> Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Bugs: 328532
> http://bugs.kde.org/show_bug.cgi?id=328532
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> PMC didn't used to remember the playlist I was on the last time, when restarting it.
> Now it saves the "lastPlaylist" while closing in the settings, and when starting it loads the value of "lastPlaylist" in settings
>
>
> Diffs
> -----
>
> libs/mediacenter/playlistmodel.cpp dccaf52
>
> Diff: https://git.reviewboard.kde.org/r/118767/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashish Madeti
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140619/1e820961/attachment.html>
More information about the Plasma-devel
mailing list