Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

[Aleix Pol Gonzalez]

> On June 19, 2014, 4:26 p.m., David Edmundson wrote:
> > This patch doesn't include Plasma's SectionScroller, so it would be a regression.
> > However I'm not entirely sure what SectionScroller actually does, so possibly not an important one.

Shouldn't we either commit to the review request or discard it by now?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114283/#review60536
-----------------------------------------------------------


On Dec. 3, 2013, 7:09 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114283/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 7:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Use QtQuickControls ScrollView internally
> 
> Flickable has a very odd API in which contentHeight can't be trusted. we need to update our ScrollBars/ScrollArea to make use of the new
> originX and originY in order to fix a lot of bugs that we currently see with scrollbars.
> 
> Instead of doing that, by porting to use QtQuick Controls we get all
> these bug fixes as well as _significantly_ reducing our code.
> 
> Having a separate logic vs UI, makes things (IMHO) easier to read.
> 
> I don't expect to merge this as-is; I haven't included the plasma
> feature that creates a SectionScroller if the content is a listview, but
> that should be viable. As far as I know all other features (keyboard
> controls / hiding buttons on touch screens) are still kept.
> 
> Files removed are as indication as to long term changes from making this
> change, in order to do that we need to port all users from ScrollBars ->
> ScrollArea. (which is worth doing anyway IMHO)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/ScrollBar.qml 93d7baf 
>   src/declarativeimports/plasmacomponents/qml/private/ScrollBarDelegate.qml 6b5edf0 
>   src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml 20cd943 
> 
> Diff: https://git.reviewboard.kde.org/r/114283/diff/
> 
> 
> Testing
> -------
> 
> Widget Explorer in plasma-shell looks exactly as before.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140619/9fba4ba9/attachment.html>