Review Request 118824: Fix for "Bug 336414 - Playlist switching doesnt move highlight"

[Ashish Madeti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118824/
-----------------------------------------------------------

(Updated June 19, 2014, 2:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Bugs: 336414
    http://bugs.kde.org/show_bug.cgi?id=336414


Repository: plasma-mediacenter


Description
-------

Whenever we added / removed any playlist, the highlight was stuck at one point i.e changing the playlist after that was not changing the highlight.

This was happening because we were directly assigning value to "multiplePlaylistList.currentIndex" in qml code, which removed its previous binding. Instead we should emit the currentIndexChanged() signal and let the ListView do the rest.


Diffs
-----

  libs/mediacenter/multipleplaylistmodel.cpp 87601f5 
  mediaelements/playlist/MultiplePlaylists.qml 4b085fe 

Diff: https://git.reviewboard.kde.org/r/118824/diff/


Testing
-------

Changed playlist after adding / removing a playlist. Now highlight is working fine


Thanks,

Ashish Madeti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140619/231a6d65/attachment.html>