Review Request 118838: Don't require mandatory subText in tooltip

David Edmundson david at davidedmundson.co.uk
Thu Jun 19 13:11:57 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118838/
-----------------------------------------------------------

(Updated June 19, 2014, 1:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

Don't require mandatory subText in tooltip

I wasted ages yesterday trying to work out why my tooltip wasn't showing in my code; turns out it's because I didn't have a subtext.
Besides the current implementation is broken; if the tooltip is already showing somewhere else then this check is skipped entirely.


Diffs
-----

  src/declarativeimports/core/tooltip.cpp 11aaaff 

Diff: https://git.reviewboard.kde.org/r/118838/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140619/47d57bfd/attachment.html>


More information about the Plasma-devel mailing list